Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RANKING_URL to the current ranking #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

debruijn
Copy link

@debruijn debruijn commented Aug 20, 2024

Without this change, the ranking that is pulled is always the one from March 5 2024. With this change, it will use the .../ranking/teams URL that automatically resolves into the current ranking.

Potential alternatives:

  • Add a date input to get_ranking() to allow the user to specify which ranking to pull (-> the ranking most recently before / on the given input date). The default would be to pull the current one.
  • Move the URL variables into the class as attributes, such that a user could override, either within an instance of the class or by making a child class.

Edit: I now see this implements the request in issue #5

Without this change, the ranking that is pulled is always the one from March 5 2024. With this change, it will use the .../ranking/teams URL that automatically resolves into the current ranking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant