Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulated pixel data of odd-length writes padding byte in incorrect location #293

Closed
richard-viney opened this issue Jul 17, 2022 · 2 comments · Fixed by #294
Closed
Labels

Comments

@richard-viney
Copy link
Contributor

A padding byte for odd-length encapsulated binary data is currently being written at the end of writing the OB tag, but padding bytes need to be written for each frame, not the whole tag. That is, the last fragment for each frame should get a padding byte if that frame's data is of uneven length. This is the behaviour of pydicom.

Will open a PR containing a fix and test shortly.

@richard-viney
Copy link
Contributor Author

A PR has been opened that fixes this issue and adds a unit test for the OB tag writing.

pieper pushed a commit that referenced this issue Jul 21, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.24.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant