Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR support with Cornerstone 3D - multi-frame DICOM files #318

Open
md-prog opened this issue Oct 4, 2022 · 1 comment
Open

SR support with Cornerstone 3D - multi-frame DICOM files #318

md-prog opened this issue Oct 4, 2022 · 1 comment

Comments

@md-prog
Copy link
Contributor

md-prog commented Oct 4, 2022

When saving an SR onto a multi-frame DICOM file, the frame number information are not being saved at all.

The reason is that dcmjs tries to detect multi-frame feature of a DICOM file, purely by sopClassID, and as we don't have all possible sopClassIDs in the comparison routine, measurement SRs are not working properly with many multi-frame DICOM files.

if (Normalizer.isMultiframeSOPClassUID(sopClassUID)) {

static isMultiframeSOPClassUID(sopClassUID) {

@pieper
Copy link
Collaborator

pieper commented Oct 4, 2022

Thanks for reporting. Yes, adding all multiframe SOPClasses to the list would be good.

md-prog added a commit to md-prog/dcmjs that referenced this issue Oct 7, 2022
md-prog added a commit to md-prog/dcmjs that referenced this issue Oct 7, 2022
pieper pushed a commit that referenced this issue Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants