fix(dcmjs): Add a set of accessors to the sequence list so the API is more consistent #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to make the naturalize data objects more consistent. This change minimally affects the API, but makes it possible to consistently be accessed, rather than having the naturalize/denaturalize produce inconsistent results.
There are no circular reference here. The change makes sequence objects remain lists, but adds an accessor so that child properties can consistently be accessed on the top level object. That is, suppose the per frame groups is a sequence with 1 element, then:
Also, if you modify any existing key of seq[0], it will be reflected in seq, and vice-versa. however, adding a key to seq[0] will not automatically add it to seq or vice-versa.