Fix retrieve seg referenced instance #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieper
approved these changes
Mar 24, 2022
pieper
added a commit
that referenced
this pull request
Mar 24, 2022
Account for bad semantic release commit in #256
pieper
added a commit
that referenced
this pull request
Mar 24, 2022
Account for bad semantic release commit in #256
|
🎉 This PR is included in version 0.19.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wayfarer3130
pushed a commit
to cornerstonejs/cornerstone3D
that referenced
this pull request
Jan 20, 2023
Account for bad semantic release commit in dcmjs-org/dcmjs#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression #255 from #253.
After talking with David and in the light of the regression, we decided to first use the ReferencedSOPInstanceUID and then other logics (in the case ReferencedSOPInstanceUID is missing)