Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for specific character set #291

Merged
merged 3 commits into from
Jul 10, 2022
Merged

added support for specific character set #291

merged 3 commits into from
Jul 10, 2022

Conversation

florianlink
Copy link
Contributor

refactored VR classes
refactored reading/writing ascii and encoded strings
changed hex writing to direct uint8 writing
reimplemented null padded read
removed unused code
unified test data loading and cache the test data locally for faster test runs

this fixes: #84

flink added 2 commits July 9, 2022 11:06
refactored VR classes
refactored reading/writing ascii and encoded strings
changed hex writing to direct uint8 writing
reimplemented null padded read
removed unused code
unified test data loading and cache the test data locally for faster test runs
@florianlink
Copy link
Contributor Author

Looks like some tests have been added after my fork, I will merge them into my branch and port them as well.
By the way, all these log.error("Invalid vr type " + type + " - using OW"); etc. make it hard to read the real errors.
Maybe we could tackle that issue as well? Many of the example datasets cause these error logs (already before my changes).

@pieper
Copy link
Collaborator

pieper commented Jul 9, 2022

Yes, thank you @florianlink 👍 I agree the log.error messages add a lot of noise. The testing framework has been evolving lately and any suggested fixes would be very welcome.

@florianlink
Copy link
Contributor Author

I fixed the failing test, I overlooked one test case and it worked because of the previously downloaded file on my machine.

@pieper pieper merged commit bfd6693 into dcmjs-org:master Jul 10, 2022
@github-actions
Copy link

🎉 This PR is included in version 0.24.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toUTF8Array will convert ° into °
2 participants