fix: several issues with character set handling #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2022
|
This is looking good - thanks for the contribution 👍 Let me know when it's ready to merge. |
|
The only additional change I think is warranted is to throw an exception on an attempt to use multiple character sets, because this isn't currently supported. If ignoreErrors is set to true we would allow parsing to proceed and emit a warning similar to the existing one. Seem reasonable? |
- Fix several character sets not working, e.g. "ISO_IR 13" and "ISO_IR 166" - Fix warning being shown when the "ISO_IR 6" character set is used - Add tests for reading encoded string data in several different character sets - Throw exception on an unsupported character set or multiple character sets rather than logging and continuing on (this can be overridden by setting ignoreErrors)
|
I've added the changes to throw an exception on multiple character sets as well. Setting |
|
Good to merge now 👍 |
pieper
approved these changes
Aug 1, 2022
|
🎉 This PR is included in version 0.24.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
encodingMappingwas based on code inpydicomas well as the DICOM spec.