-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the CLI to use Go 1.12. #1443
Conversation
@mesosphere-ci run integration tests |
Waiting for docker-library/golang#264 to be merged. |
We should be able to simplify this by using Lines 234 to 244 in b4a7d91
Wanna give it a try in this PR? |
@mesosphere-ci run integration tests |
c724662
to
e2fefe7
Compare
@mesosphere-ci run integration tests |
e2fefe7
to
385a846
Compare
385a846
to
562ad34
Compare
562ad34
to
61cd1d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will have to wait for Appveyor to support Go 1.12. If they do not do it soon we'll investigate on alternative.
For Appveyor: appveyor/ci#2875 |
@mesosphere-ci run integration tests |
@mesosphere-ci run integration tests |
This does not change our supported operating systems, Go 1.12 being the
last release supporting macOS 10.10 Yosemite.