Skip to content

Commit

Permalink
fix(types): add skipLibCheck bc conflicting cypress- and jest-types
Browse files Browse the repository at this point in the history
we now trust .d.ts-files blindly, mostly because the mocha shipped by cypress
conflicts with jest otherwise. an alternative approach would be to whitelist
@types per `"types": ["jest", "graphql", ...],`, but as this introduces a
high chance of forgetting to add new libs here, we stick with skipLibCheck.

-------------------

to learn more, you might want to look here:
cypress-io/cypress#1087
  • Loading branch information
pierrebeitz authored and juliangieseke committed Mar 4, 2019
1 parent 01d8454 commit 2c67e0d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"baseUrl": "./",
"skipLibCheck": true,
"paths": {
"@dcos/http-service": ["src/typings/dcos__http-service"],
"*": ["*", "packages/*", "src/typings/*"],
Expand Down

0 comments on commit 2c67e0d

Please sign in to comment.