Message: add References and In-Reply-To headers shortcuts
#230
Conversation
src/Message/AbstractMessage.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| final public function getReferences() |
src/Message/AbstractMessage.php
Outdated
| $references = $this->getHeaders()->get('references'); | ||
|
|
||
| if (\is_array($references)) { | ||
| return \array_unique($references); |
There was a problem hiding this comment.
I don't like it very much to alter a header content. Emailing is a brittle system full of exceptions: even though it seems harmless, I would prefer to let the user do it if needed.
src/Message/AbstractMessage.php
Outdated
| return \array_unique($references); | ||
| } | ||
|
|
||
| return []; |
There was a problem hiding this comment.
We can use a single return with ternary operator:
return \is_array($references) ? $references : [];
tests/MessageTest.php
Outdated
|
|
||
| $message = $this->mailbox->getMessage(1); | ||
|
|
||
| $this->assertSame(2, \count($message->getReferences())); |
tests/fixtures/references.eml
Outdated
| Message-ID: <[email protected]> | ||
| From: no_host | ||
| Cc: "This one: is \"right\"" <[email protected]>, No-address | ||
| References: <[email protected]> <[email protected]> |
There was a problem hiding this comment.
Would you be so kind to also add the same API for In-Reply-To header?
https://tools.ietf.org/html/rfc4021#section-2.1.9
https://tools.ietf.org/html/rfc2822#section-3.6.4
It seems to have exactly the same behaviour.
tests/MessageTest.php
Outdated
|
|
||
| $message = $this->mailbox->getMessage(2); | ||
|
|
||
| $this->assertSame(0, \count($message->getReferences())); |
|
|
||
| $message = $this->mailbox->getMessage(1); | ||
|
|
||
| $this->assertCount(2, $message->getReferences()); |
There was a problem hiding this comment.
Please add also specific assertion to the content of the referencies, e.g. $this->assertContains('<[email protected]>, $message->getReferences());'
| * | ||
| * @return array | ||
| */ | ||
| final public function getInReplyTo(): array |
There was a problem hiding this comment.
Please add these two new signatureto Message\BasicMessageInterface
Slamdunk
changed the title
References and In-Reply-To headers shortcuts
|
Thank you @wujku |
No description provided.