Skip to content

Commit

Permalink
Fix reporting of errors on Windows
Browse files Browse the repository at this point in the history
When winpty exceptions occurred they were silently failing due
to marshal not being initialized.

Part of chjj#102
Part of chjj#103
  • Loading branch information
Tyriar committed Jul 9, 2017
1 parent abb0a37 commit e9116e1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/win/pty.cc
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,14 @@ static NAN_METHOD(PtyStartProcess) {
std::string conoutPipeNameStr(conoutPipeNameWStr.begin(), conoutPipeNameWStr.end());
marshal->Set(Nan::New<v8::String>("conout").ToLocalChecked(), Nan::New<v8::String>(conoutPipeNameStr).ToLocalChecked());
}
info.GetReturnValue().Set(marshal);

goto cleanup;

cleanup:
delete filename;
delete cmdline;
delete cwd;

info.GetReturnValue().Set(marshal);
}

/*
Expand Down

0 comments on commit e9116e1

Please sign in to comment.