Rubocop setup #148
Merged
Rubocop setup #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlestavel
force-pushed
the
rubocop
branch
2 times, most recently
from
f8a8a72 to
5359b8f
Compare
jlestavel
commented
Dec 20, 2022
jlestavel
commented
Dec 20, 2022
jlestavel
force-pushed
the
rubocop
branch
2 times, most recently
from
d009fd8 to
20810e3
Compare
|
@deanpcmad rebased on I think it would help future contributors to have Rubocop setup! |
|
Seeing as you've fixed the tests which are now in master, should be able to rebase :) |
|
✅ that's done! |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is introducing the Rubocop Ruby linter/formatter for the
sidekiq-limit_fetchrepository.To review this PR, I suggest that you use the "Hide whitespace option", as there are some classes that are re-indented because of the
Style/ClassAndModuleChildrencop.To generate this PR, I mostly use the Rubocop autocorrect option.
I came upon this subject while working on #142