-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix queues value #155
fix queues value #155
Conversation
4405764
to
97084a6
Compare
I tried your fix. Starting Sidekiq now works as expected, but exiting Sidekiq leads to the following exception /Users/me/.rvm/gems/ruby-3.1.2@project/gems/sidekiq-7.0.3/lib/sidekiq/fetch.rb:31:in
|
adc7f78
to
b222c01
Compare
Thank you for your comment. |
Hi, I tried again but weirdly enough I get the original exception back:
undefined method `to_sym' for ["active_storage_analysis", 4]:Array
queue.process_limit = @process_limits[queue_name.to_s] || @process_limits[queue_name.to_sym]
^^^^^^^
Did you mean? to_s
to_set
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/limit_fetch/queues.rb:139:in `apply_process_limit_to_queue'
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/limit_fetch/queues.rb:133:in `block in apply_process_limit_to_queues'
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/limit_fetch/queues.rb:132:in `each'
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/limit_fetch/queues.rb:132:in `apply_process_limit_to_queues'
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/limit_fetch/queues.rb:34:in `start'
***@***.***/bundler/gems/sidekiq-limit_fetch-9ba331acab4c/lib/sidekiq/extensions/manager.rb:17:in `start'
***@***.***/gems/sidekiq-7.0.3/lib/sidekiq/launcher.rb:42:in `each'
As you can see I use Sidekiq 7.0.3. And used this in my gemfile for your Fork:
gem "sidekiq-limit_fetch", git: "https://github.com/uichi/sidekiq-limit_fetch.git"
… Op 18 jan. 2023, om 17:54 heeft uichi ***@***.***> het volgende geschreven:
Thank you for your comment.
I pushed new commit. Can you check the behavior?
—
Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACY2N2S25JHDRJ7OUOOMXLWTAN6HANCNFSM6AAAAAAT5XUJUM>.
You are receiving this because you commented.
|
Thank you. |
Yes, that was it! Thanks! I forgot to mention the branch.
It starts and stops without exceptions now.
… Op 19 jan. 2023, om 12:18 heeft uichi ***@***.***> het volgende geschreven:
Thank you.
Did you use sidekiq-v7-fix-queues-value branch of my Fork ? I tried fixed sidekiq-limit_fetch on my development environment and no problems occurred.
—
Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACY2N7CS4M7NJX6TCAAHD3WTEPHBANCNFSM6AAAAAAT5XUJUM>.
You are receiving this because you commented.
|
Thanks! |
Fixes #153.
The
undefined method to_sym
is occurred whenqueues
have array in asidekiq.yml
. Ifqueues
have queue name and weighting,config[:queues]
also get queue name and weighting. I think thatconfig[:queues]
have only queue name. Therefore , I tried to get only the queue name ifconfig[:queues]
have weighting besides queue name.