Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security error on safari #167

Closed
yields opened this issue Jan 6, 2015 · 3 comments
Closed

security error on safari #167

yields opened this issue Jan 6, 2015 · 3 comments

Comments

@yields
Copy link
Contributor

yields commented Jan 6, 2015

When a user disables localstorage / cookies in safari window.onerror is invoked with security error.
I'm not sure what the correct thing this module should do though, i'm just opening this issue to see what you think ;)

@TooTallNate
Copy link
Contributor

Hmmm, well we already have try/catch around the localStorage access calls. I wonder if anybody has documented a workaround for this before...

@yields
Copy link
Contributor Author

yields commented Jan 6, 2015

Oh the error is thrown here: https://github.com/visionmedia/debug/blob/master/browser.js#L24 not sure if this happens in other browsers too.

@TooTallNate
Copy link
Contributor

Oh ok. So lets try throwing a try/catch around that part of the code as
well? (Ideally hoisting it out into its own function so that the entire
module doesn't get de-optimized because of the module-level try/catch).

On Tue, Jan 6, 2015 at 11:54 AM, Amir Abu Shareb [email protected]
wrote:

Oh the error is thrown here:
https://github.com/visionmedia/debug/blob/master/browser.js#L24 not sure
if this happens in other browsers too.


Reply to this email directly or view it on GitHub
#167 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants