Consider making isValid something other than an instance method (custom widgets).

[knpwrs]

When a custom widget with an isValid method is wrapped in a HOC, the following error is thrown when attemping to publish:

Uncaught TypeError: r.wrappedControlValid is not a function

It looks like wrappedControlValid is never set because my HOC is a stateless component, meaning it cannot be ref'd. The function which sets wrappedControlValid returns immediately if a ref is not possible: https://github.com/netlify/netlify-cms/blob/a5d4fd41a4a1f681b117bf6f40ce1263382680a9/src/components/Editor/EditorControlPane/Widget.js#L56-L67

I can probably temporarily fix this with toClass() from recompose, though I'd argue that instance methods on components are sort of a React anti-pattern. I think it would probably be better to pass an isValid prop to the custom widgets. This change would ideally be done in a backwards-compatible way as to not bump the major version.

[knpwrs]

A quick fix could be something along the lines of what glamorous does as well: allow custom widgets to accept an innerRef prop (or similar) to allow a ref to pass down through to the wrapped component. There might also be something we can do with the newer React.forwardRef API.

[erquhart]

Agreed, definitely open to a PR for this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[martinjagodic]

Closing as stale