fix(core): list widget default values #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview proposed changes to netlifycms.org in the link below: Built with commit d2046ff |
|
Preview proposed changes to the CMS demo site in the link below: Built with commit d2046ff |
erquhart
suggested changes
Jun 13, 2019
| return fields.reduce((acc, item) => { | ||
| const subfields = item.get('field') || item.get('fields'); | ||
| const list = item.get('widget') == 'list'; | ||
| const name = item.get('name'); | ||
| const defaultValue = item.get('default', null); | ||
| const isEmptyDefaultValue = val => [[{}], {}].some(e => isEqual(val, e)); | ||
| let subDefaultValue; |
There was a problem hiding this comment.
We can declare a constant for this in each conditional and avoid mutations.
This was referenced Jun 13, 2019
erquhart
approved these changes
Jun 14, 2019
nathankitchen
pushed a commit
to nathankitchen/netlify-cms-backend-azure
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
createEmptyDraftDatafunction creates an empty array object[{}]and object{}value forlistandobjectwidgets without any default value specified in the config file which in turn forces an empty field(s) for thelistwidget in the editor page. Also for singlelistfieldwidget with config default key set, the default value generated should come like so['default value']but outputs something like[{widget_name: 'default value'}]which should be fine if it's alistfieldswidget. This PR fixes both issues.