-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add EOL for files #7039
fix: add EOL for files #7039
Conversation
✅ Deploy Preview for decap-www canceled.
|
@razonyang the tests are failing because Cypress fixtures don't match anymore. Could you update these too, please? |
Hi @martinjagodic, I'm willing to correct it, but I lost my direction after digging into the code, could you please share some hint? |
hi @razonyang I hope you don't mind me taking this over, but currently recording fixtures does not really work because the whole cypress part is awaiting a large overhaul. The process that I currently use is quite manual and specific, so I will describe it here for future reference (also for me and @martinjagodic). I wanted to write these instructions but after I was finished the tests were working already, so it didn't make sense to me to make you do them again :) a) run |
@demshy Of course I don't mind, I'm completely newbie on this project, I have no idea on how to fix the tests, now I learned it from your code. |
No worries, it's quite overwhelming for most of us. Anyhow, this seemed to do the trick |
Closes #1382
Summary
Test plan
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)