Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to take this project: direction, thoughts, proposals #1

Closed
decentral1se opened this issue Jul 22, 2018 · 3 comments
Closed

Where to take this project: direction, thoughts, proposals #1

decentral1se opened this issue Jul 22, 2018 · 3 comments

Comments

@decentral1se
Copy link
Owner

Following the recommendation in python/typeshed#1702 (comment) of:

I actually recommend waiting for PEP 561 and its implementation. Having incomplete stubs in typeshed (which I presume the machinalis stubs are) is worse than no stubs, as we've found out with some other packages (sqlalchemy was actually withdrawn for this reason).

I think we need to orientate the development of this repository specifically around how PEP 561 will work and whatever work flow is necessary to support that integration.

There are some notes around this on the mypy documentation:

I see no existing ticket regarding adding type hints on the Django tracker:

It probably makes sense to drop a mail on the dev list to see where we can coordinate.

Open to any thoughts!

I can put an hour or two each week and use Django in my day to day work, so I would definitely like to have access to the type hint system going forward. It's also a way to give back to the Django community which really has got me a long way so far ...

@decentral1se
Copy link
Owner Author

Here's some discussions from the Django development mailing list:

Oh, right, it seems someone has already started to do this:

However, I then saw this:

The JetBrains announcement that they want to fund the project isn't a guarantee that it'll be implemented. The feature needs to go through the normal feature acceptance process, which as Markus said, might involve a DEP.

Assuming the idea is accepted, my sense on timing would be to wait until January when Django drops support for Python 2.7 and 3.4 in master. Then we could use inline annotations rather than the stub files.

Past discussions of type hinting:
https://groups.google.com/d/topic/django-developers/z_P1TvJ6QG8/discussion
https://groups.google.com/d/topic/django-developers/xOTmq93YZuQ/discussion

It seems others were waiting for PEP 561 as well.

I'll create a new mail on the development list and see what kind of traction it gets.

@decentral1se
Copy link
Owner Author

decentral1se commented Jul 22, 2018

Just fired a mail at https://groups.google.com/forum/#!forum/django-developers.

Hasn't appeared just yet but should at some point. Hopefully discussion moves along there.

EDIT: https://groups.google.com/forum/#!topic/django-developers/xB3kla9RJbo

@decentral1se
Copy link
Owner Author

decentral1se commented Jul 30, 2018

Closing off, things have come along, we're focusing work over at:

https://github.com/TypedDjango/django-stubs#django-stubs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant