Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django #1702

Closed
dilyanpalauzov opened this issue Oct 31, 2017 · 6 comments
Closed

Django #1702

dilyanpalauzov opened this issue Oct 31, 2017 · 6 comments
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed

Comments

@dilyanpalauzov
Copy link

Integrate https://github.com/machinalis/mypy-django into typeshed.

I am aware of #153 but until this is resolved the last stable version can be exposed by typeshed. This is what most people will use and having it is better than not having django type hints.

@gvanrossum
Copy link
Member

I actually recommend waiting for PEP 561 and its implementation. Having incomplete stubs in typeshed (which I presume the machinalis stubs are) is worse than no stubs, as we've found out with some other packages (sqlalchemy was actually withdrawn for this reason).

@decentral1se
Copy link

Trying to pick up the situation here but can I just check what was meant by 'I actually recommend waiting for PEP 561 and its implementation' @gvanrossum. I see that there are 3 methods of including types and not sure what was meant. Thanks.

@PiDelport
Copy link

I'm assuming this would mean a separate Django-stubs package.

@gvanrossum
Copy link
Member

gvanrossum commented Jul 29, 2018 via email

@decentral1se
Copy link

OK, makes sense. We're going to try and bring about this django-stubs package. Kicking off at:

https://github.com/TypedDjango/django-stubs#django-stubs

@srittau srittau added stubs: request OUTDATED! Request to add stubs for a new package to typeshed size-large labels Sep 11, 2018
@srittau
Copy link
Collaborator

srittau commented Aug 26, 2020

We are closing all third-party stub requests issues without recent activity. We still welcome pull requests that add these to typeshed, although distributing the stubs with the the third-party package itself is preferable.

@srittau srittau closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed
Projects
None yet
Development

No branches or pull requests

5 participants