-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the use of Resolver
type from did-resolver
is too restrictive
#158
Comments
Resolver
type from did-resolver
is to restrictiveResolver
type from did-resolver
is too restrictive
mirceanis
added a commit
that referenced
this issue
Mar 24, 2021
mirceanis
added a commit
that referenced
this issue
Mar 25, 2021
🎉 This issue has been resolved in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Resolver
class fromdid-resolver
is declared with the private fields included, which makes it hard to implement matching type signatures.For example, the following object cannot be used directly in
verifyJWT
or similar methods that requireResolver
.The error is :
or
There is a workaround to use something like
(resolver as unknown) as Resolver
but this is not intuitive and annoying.Only the required signature of the Resolver type should be required by this lib; without the private members.
The text was updated successfully, but these errors were encountered: