Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][deps] the update of uint8arrays>3.x and multiformats>9.x caused broken builds in CommonJS projects #301

Closed
mirceanis opened this issue Oct 31, 2023 · 3 comments · Fixed by #302
Closed

[BUG][deps] the update of uint8arrays>3.x and multiformats>9.x caused broken builds in CommonJS projects #301

mirceanis opened this issue Oct 31, 2023 · 3 comments · Fixed by #302
Labels
bug Something isn't working dependencies Pull requests that update a dependency file question Further information is requested released

Comments

@mirceanis
Copy link
Member

mirceanis commented Oct 31, 2023 •
edited
Loading

As explained by @nklomp in decentralized-identity/did-jwt-vc#135, a dependency update was made that cascaded into broken builds.

This library is still being built as both CJS and ESM, but these 2 dependencies stopped publishing CJS variants in recent versions.
Unfortunately the maintainers of the above libraries don't want to publish CJS variants of their libraries so one of the few options remaining is to downgrade those dependencies here to ameliorate the annoyance for users of this library.

The JS world seems to be moving toward ESM but it is painfully slow and annoyingly difficult to support both.
I'm posting this issue here to gauge the support for the downgrade.

👍 downgrade / 👎 do nothing ?
@mirceanis mirceanis added the bug Something isn't working label Oct 31, 2023
@nklomp
Copy link
Member

nklomp commented Oct 31, 2023

Double negatives :P Downgrade is thumbsup right? ;)

IMO given the amount of issues people face right now, a downgrade makes sense, until you move the lib itself to full ESM.

mirceanis added a commit that referenced this issue Oct 31, 2023
@mirceanis
fix(deps): downgrade uint8arrays and multiformats
2612bf1 
fixes #301
@mirceanis
Copy link
Member Author

Double negatives :P Downgrade is thumbsup right? ;)

Good point, I edited my comment to be more clear about the meaning of the emojis :)

@mirceanis mirceanis added question Further information is requested dependencies Pull requests that update a dependency file labels Oct 31, 2023
@mirceanis mirceanis mentioned this issue Oct 31, 2023
Merged
mirceanis added a commit that referenced this issue Oct 31, 2023
@mirceanis
fix(deps): downgrade uint8arrays and multiformats
80a3502 
fixes #301
@mirceanis mirceanis mentioned this issue Oct 31, 2023
Closed
mirceanis added a commit that referenced this issue Nov 1, 2023
@mirceanis
fix(deps): downgrade uint8arrays and multiformats (#302)
4bf8001 
fixes #301
uport-automation-bot pushed a commit that referenced this issue Nov 1, 2023
@semantic-release-bot
chore(release): 7.4.5 [skip ci]
cd7e0ee 
## [7.4.5](7.4.4...7.4.5) (2023-11-01)

### Bug Fixes

* **deps:** downgrade uint8arrays and multiformats ([#302](#302)) ([4bf8001](4bf8001)), closes [#301](#301)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 7.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file question Further information is requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): downgrade uint8arrays and multiformats decentralized-identity/did-jwt
3 participants
@mirceanis @nklomp @uport-automation-bot