-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace revoke
operation as deactivate
operation instead
#321
Comments
Is this really https://w3c.github.io/did-core/#deactivate ? I suggest that deactivated DIDs have their total information minimized, forensic analysis will return all the versions before the point of deactivation, but I still think it would be wise to set the DID Document to basically:
Is there a reason why the DID Document should retain anything that would be useful for correlation in a deactivated state? Certainly the user will not be able to do anything about it, after the fact. |
There's an older issue about this in the DID resolution spec repo.. After a DID has been deactivated, and you resolve it, do you get back a DID document with a special flag (as in your example), or do you get back a null value, or does the DID resolver raise an error? |
I put this on the agenda for tomorrow's DID resolution call, in case you have time: https://docs.google.com/document/d/1qYBaXQMUoB86Alquu7WBtWOxsS8SMhp1fioYKEGCabE/ |
Thanks @OR13 and @peacekeeper, this definitely sounds like deactivate as you pointed out. Will implement it to spec if it is specified. Adding @csuwildcat and @mudiali to see if they have extra inputs. |
@thehenrytsai we should rename all of our Revoke refs and update the docs/spec to reflect Deactivate as the operation type. I can update the spec. |
delete
operation as revoke
insteadrevoke
operation as deactivate
operation instead
implemented |
@thehenrytsai @csuwildcat I'm removing the spec v1 label, as this is implemented there. |
I believe this change is now reflected everywhere in the spec as of #523, but eyes-on would help validate. |
delete
in code and documentation asrevoke
going forward.recover
key.The text was updated successfully, but these errors were encountered: