Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace revoke operation as deactivate operation instead #321

Closed
thehenrytsai opened this issue Oct 29, 2019 · 8 comments
Closed

Replace revoke operation as deactivate operation instead #321

thehenrytsai opened this issue Oct 29, 2019 · 8 comments
Assignees
Labels
documentation Update to doc files feature A new implementation feature request protocol Sidetree protocol change proposal

Comments

@thehenrytsai
Copy link
Collaborator

  1. Replace all referenced to delete in code and documentation as revoke going forward.
  2. Disambiguate the revoked from not-found when resolving.
  3. Revocation must be performed by recover key.
  4. Revocation is the final valid operation.
@thehenrytsai thehenrytsai added protocol Sidetree protocol change proposal documentation Update to doc files feature A new implementation feature request labels Oct 29, 2019
@OR13
Copy link
Contributor

OR13 commented Oct 29, 2019

Is this really https://w3c.github.io/did-core/#deactivate ?

I suggest that deactivated DIDs have their total information minimized, forensic analysis will return all the versions before the point of deactivation, but I still think it would be wise to set the DID Document to basically:

{
"@context": "...",
"id":  "did:example:123",
"deactivated": true
}

Is there a reason why the DID Document should retain anything that would be useful for correlation in a deactivated state? Certainly the user will not be able to do anything about it, after the fact.

@peacekeeper
Copy link
Member

There's an older issue about this in the DID resolution spec repo.. After a DID has been deactivated, and you resolve it, do you get back a DID document with a special flag (as in your example), or do you get back a null value, or does the DID resolver raise an error?
See here: w3c/did-resolution#5

@peacekeeper
Copy link
Member

I put this on the agenda for tomorrow's DID resolution call, in case you have time: https://docs.google.com/document/d/1qYBaXQMUoB86Alquu7WBtWOxsS8SMhp1fioYKEGCabE/

@thehenrytsai
Copy link
Collaborator Author

Thanks @OR13 and @peacekeeper, this definitely sounds like deactivate as you pointed out. Will implement it to spec if it is specified. Adding @csuwildcat and @mudiali to see if they have extra inputs.

@OR13 OR13 added the Spec v1 label Mar 20, 2020
@csuwildcat
Copy link
Member

@thehenrytsai we should rename all of our Revoke refs and update the docs/spec to reflect Deactivate as the operation type. I can update the spec.

@thehenrytsai thehenrytsai changed the title Revisit/replace delete operation as revoke instead Replace revoke operation as deactivate operation instead Mar 25, 2020
@OR13
Copy link
Contributor

OR13 commented Mar 26, 2020

implemented

@OR13 OR13 closed this as completed Mar 26, 2020
@OR13 OR13 reopened this Mar 26, 2020
@OR13
Copy link
Contributor

OR13 commented Mar 31, 2020

@thehenrytsai @csuwildcat I'm removing the spec v1 label, as this is implemented there.

@OR13 OR13 removed the Spec v1 label Mar 31, 2020
@isaacJChen isaacJChen added the beta label Apr 2, 2020
@csuwildcat
Copy link
Member

I believe this change is now reflected everywhere in the spec as of #523, but eyes-on would help validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Update to doc files feature A new implementation feature request protocol Sidetree protocol change proposal
Projects
None yet
Development

No branches or pull requests

5 participants