Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement loader promotion VTEX #988

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

gabriel-kerchner
Copy link
Contributor

@gabriel-kerchner gabriel-kerchner commented Jan 13, 2025

What is this Contribution About?

Create a new loader based in Promotion of VTEX

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

https://www.loom.com/share/6af669d362964e8aa67e72594f2b6c9e?sid=89ffa666-07be-4a10-a1fc-aad389b53b4a

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.64.16 update
  • 🎉 for Minor 0.65.0 update
  • 🚀 for Major 1.0.0 update

Copy link
Contributor

@IncognitaDev IncognitaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the blog and konfidency manifest.gen.ts of this PR?

vtex/loaders/promotion/getPromotionById.ts Show resolved Hide resolved
@matheusgr matheusgr merged commit 30d1d4e into deco-cx:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants