-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DE-3424: Initial SDK implementation (WIP) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
added a commit
that referenced
this pull request
Jun 8, 2023
gunnarmorling
added a commit
that referenced
this pull request
Jun 9, 2023
gunnarmorling
added a commit
that referenced
this pull request
Jun 9, 2023
gunnarmorling
added a commit
that referenced
this pull request
Jun 9, 2023
rmetzger
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized half way through that this is a draft PR. Still posting the comments I have so far.
...n/custom-pipelines-hello-world/src/main/java/co/decodable/examples/cpdemo/DataStreamJob.java
Outdated
Show resolved
Hide resolved
...n/custom-pipelines-hello-world/src/main/java/co/decodable/examples/cpdemo/DataStreamJob.java
Outdated
Show resolved
Hide resolved
...n/custom-pipelines-hello-world/src/main/java/co/decodable/examples/cpdemo/DataStreamJob.java
Show resolved
Hide resolved
...stom-pipelines-hello-world/src/test/java/co/decodable/examples/cpdemo/DataStreamJobTest.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/co/decodable/sdk/internal/DecodableStreamSourceBuilderImpl.java
Outdated
Show resolved
Hide resolved
gunnarmorling
added a commit
that referenced
this pull request
Jun 13, 2023
gunnarmorling
added a commit
that referenced
this pull request
Jun 13, 2023
And applied. Thx for reviewing, @rmetzger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rmetzger and @nicoweidner, this is all still very much in flux, but here's a draft PR for the upcoming SDK. It's fundamentally working, see the test for an end-to-end example. Feedback welcome, just focus on the high-level aspects at this point, polishing will come later. Thanks!
In terms of the general design, the idea is to have wrappers around Flink's Kafka source and sink,
DecodableStreamSource
andDecodableStreamSource
; they are used like so, i.e. like any other Flink source or sink:The topic name mappings, bootstrap servers, and any other potentially needed info is injected via env vars. Users should only ever work with the API in
co.decodable.sdk
; theinternal
package is well, internal, and mostly deals with wrapping the Kafka source and sink types (which was a PITA, but looks like I could make it work in the end).