config: Parse network interfaces. #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
network_info
branch
2 times, most recently
from
6457c14 to
5818873
Compare
dajohi
reviewed
Nov 6, 2018
dnldd
force-pushed
the
network_info
branch
2 times, most recently
from
ba441e3 to
ef36291
Compare
dnldd
force-pushed
the
network_info
branch
2 times, most recently
from
030b766 to
939e808
Compare
This adds config helpers for parsing network interface states based on the config parameters set. Work towards getnetworkinfo implementation.
davecgh
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
I'm going to go ahead and accept this since it appears correct for the time being, but is pretty dangerous code because it is making assumptions that will be very easy to accidentally break and has a ton of unnecessary error handling and conditionals.
This could be accomplished much safer and easier to read fashion by merely defining the supported networks as variables of type dcrjson.NetworksResult and setting the fields directly depending on the parsed results. I'll push a separate PR which cleans this up shortly.
|
See #1706 for the aforementioned cleanup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds config helpers for parsing network interface states based on the config parameters set.
Work towards
getnetworkinfoimplementation.