rpcserver: update block template reconstruction. #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies solved block reconstruction by removing the pkScript reassignment and regeneration of the merkle root.
davecgh
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Approving this since it accurate and strictly more correct than the existing code. Ultimately, there is no reason a copy should be needed at all, but other infrastructure changes are needed before the copy can be removed.
Waiting for external verification before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies solved block reconstruction by removing the pkScript reassignment and regeneration of the merkle root.