wire: Add tests for BlockHeader (From)Bytes. #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Feb 13, 2019
|
Thanks Dave, I'll change the PR as requested and improve it. |
|
Please let me know once this is updated. |
davecgh
changed the title
jozn
force-pushed
the
wire_header
branch
3 times, most recently
from
f72a34d to
acc4625
Compare
|
Updated. Sorry I didn't see your comment in here. |
jozn
force-pushed
the
wire_header
branch
3 times, most recently
from
c685cb5 to
ee155b7
Compare
Checking Bytes() and FromBytes() of BlockHeader works correctly.
|
This PR is finalized. |
davecgh
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increase test coverage of BlockHeader.
In following days, I will increase the test coverage of wire. Some test suites need to be refactored to allow for error paths and wrong inputs, I will keep the test cases data but reorganize them and make them more structured this will allow for increase test coverage and easier understanding and covers more samples.
I will keep the PR short and separate for each Message.
After this, I will work with other packages and increase their test coverage and quality.