txscript: Add remove signature reference test. #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 13, 2019
dajohi
approved these changes
Feb 13, 2019
An important (and easy for implementations to miss) aspect of the CHECKSIG opcodes is that the full signature (signature plus hash type) that is being checked is first removed from the script prior to calculating the signature hash against which the signature is verified. It appears the test in the upstream btcsuite code for this was removed during the initial Decred port instead of being converted as it should have been. Consequently, this converts the relevant test so it is correct for Decred and adds it to the reference tests. Note that the first of the two added tests is to ensure the original signature is valid prior to testing the actual removal condition.
davecgh
force-pushed
the
txscript_removedata_test
branch
from
ce25e2a to
1f5abad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An important (and easy for implementations to miss) aspect of the
CHECKSIGopcodes is that the full signature (signature plus hash type) that is being checked is first removed from the script prior to calculating the signature hash against which the signature is verified.It appears the test in the upstream btcsuite code for this was removed during the initial Decred port instead of being converted as it should have been.
Consequently, this converts the relevant test so it is correct for Decred and adds it to the reference tests. Note that the first of the two added tests is to ensure the original signature is valid prior to testing the actual removal condition.