Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire: Add tests for MsgCFTypes #1619

Merged
merged 1 commit into from
Feb 17, 2019
Merged

wire: Add tests for MsgCFTypes #1619

merged 1 commit into from
Feb 17, 2019

Conversation

jozn
Copy link
Contributor

@jozn jozn commented Feb 15, 2019 •
edited
Loading

This adds standard wire tests for MsgCFTypes. Things done in these
commit:

  • Add standard wire test for MsgCFTypes
  • Fix a potential bug at BtcEncode: return an error if the number
    of filter types exceed the maximum number of supported filter
    types (256)
  • Add an extended error checking for checking malformed encoded
    data returns correct errors.

@jozn
Copy link
Contributor Author

jozn commented Feb 15, 2019

Tests for other CF related will be added soon.

davecgh
davecgh requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I commented on a few style nits, but the logic of the tests is solid.

wire/msgcftypes_test.go Outdated Show resolved Hide resolved
wire/msgcftypes_test.go Outdated Show resolved Hide resolved
@davecgh davecgh added this to the 1.5.0 milestone Feb 15, 2019
@jozn jozn force-pushed the cftypes branch 2 times, most recently from 0367832 to 03144df Compare February 16, 2019 17:04
@jozn
wire: Add tests for MsgCFTypes
815fec0 
This adds standard wire tests for MsgCFTypes. Things done in these
commit:
- Add standard wire test for MsgCFTypes
- Fix a potential bug at BtcEncode: return an error if the number
	of filter types exceed the maximum number of supported filter
	types (256)
- Add an extended error checking for checking malformed encoded
	data return correct errors.
@jozn
Copy link
Contributor Author

jozn commented Feb 16, 2019

Thanks for your feedback. Changes have been made. feel free to merge.

@davecgh davecgh merged commit adc41ab into decred:master Feb 17, 2019
@jozn jozn deleted the cftypes branch February 17, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jozn @davecgh