chaincfg: Move a test to chainhash package. #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozn
force-pushed
the
chaincfg_del_test
branch
3 times, most recently
from
28ea34d to
239899d
Compare
This moves a test in chaincfg which belongs to chainhash package. The test case that has been moved has already been covered in chainhash test suite, but instead of deleting the test case it has been moved, so to have a stronger test suite.
jozn
force-pushed
the
chaincfg_del_test
branch
from
239899d to
80d15b4
Compare
jozn
changed the title
davecgh
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR: The update PR instead of just deleting the test moves it to its own package, in order not to arises controversy around deleting tests.