txscript: Introduce constant for max CLTV bytes. #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Mar 9, 2019
matheusd
approved these changes
Mar 11, 2019
As is already well commented in the code, the locktime parameter of the CHECKLOCKTIMEVERIFY opcode requires 5 bytes instead of the standard 4 bytes allowed by math opcodes. This introduces a constant for the value instead of hardcoding 5 to increase readability and potentially allow the value to be exported in the future.
davecgh
force-pushed
the
txscript_max_cltv_constant
branch
from
043239a to
b19842a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is already well commented in the code, the locktime parameter of the
CHECKLOCKTIMEVERIFYopcode requires 5 bytes instead of the standard 4 bytes allowed by math opcodes. This introduces a constant for the value instead of hardcoding 5 to increase readability and potentially allow the value to be exported in the future.