multi: Add go 1.11 directive to all modules. #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Mar 17, 2019
This adds the go 1.11 directive to all of the modules in order to clearly mark they build and work with that version. Go 1.12 modified the tools such that tidy will automatically add the new version to modules that do not already have a directive and that would prevent builds on Go 1.11 through Go 1.11.3 which is not desirable.
davecgh
force-pushed
the
multi_go1_11_mod
branch
from
b4841cc to
0f50fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the go 1.11 directive to all of the modules in order to clearly mark they build and work with that version. Go 1.12 modified the tools such that tidy will automatically add the new version to modules that do not already have a directive and that would prevent builds on Go 1.11 through Go 1.11.3 which is not desirable.