mining: Improve template key handling. #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Mar 30, 2019
dnldd
reviewed
Mar 30, 2019
davecgh
force-pushed
the
mining_improve_template_key_handling
branch
2 times, most recently
from
6948b2b to
0323424
Compare
alexlyp
approved these changes
Apr 1, 2019
This factors out the code which deals with generating a unique block template key to a separate function, modifies it to only be comprised of the merkle root + timestamp, and renames the associated variables accordingly. The separate function is useful because work submission will ultimately need to create the same key. The rationale for switching to only using the merkle root + timestamp is as follows: - It is more efficient to use smaller keys - The combination is guaranteed to be unique for every template so long as there are no more than one per second generated with the exact same txns (which is already the case with the inclusion of the stake merkle root in the key too) - There are future plans to combine the stake root and merkle roots into the merkle root field and repurpose the stake root Finally, the naming is also being changed from ID to key because the name templateID already has a distinct meaning in the rpcserver code in how it applies to long polling clients and it is better to avoid potential confusion.
davecgh
force-pushed
the
mining_improve_template_key_handling
branch
from
0323424 to
6875c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the code which deals with generating a unique block template key to a separate function, modifies it to only be comprised of the merkle root + timestamp, and renames the associated variables
accordingly. The separate function is useful because work submission will ultimately need to create the same key.
The rationale for switching to only using the merkle root + timestamp is as follows:
Finally, the naming is also being changed from ID to key because the name
templateIDalready has a distinct meaning in therpcservercode in how it applies to long polling clients and it is better to avoid potential confusion.