Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: fix recent govet findings #1727

Merged
merged 1 commit into from
Apr 29, 2019
Merged

multi: fix recent govet findings #1727

merged 1 commit into from
Apr 29, 2019

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Apr 29, 2019

blockmanager.go:736:14: nilness: tautological condition: non-nil != nil (govet)
        if template != nil {
                    ^
mining.go:854:19: nilness: tautological condition: nil == nil (govet)
                        if curTemplate == nil {
                                       ^
rpcserver.go:2949:22: nilness: impossible condition: non-nil == nil (govet)
        if expectedPrevHash == nil || !expectedPrevHash.IsEqual(prevHash) {
                            ^
rpcserver.go:3236:41: nilness: nil dereference in dynamic method call (govet)
                return nil, rpcInternalError(err.Error(),
                                                      ^
rpcserver.go:4101:15: nilness: impossible condition: non-nil == nil (govet)
                if msgBlock == nil {
                            ^

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently failing Travis.

mining.go Show resolved Hide resolved
rpcserver.go Show resolved Hide resolved
add govet to linter tests.
@davecgh davecgh merged commit 70c1404 into decred:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants