Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: Add GetMasterPubkey #1777

Merged
merged 2 commits into from
Jul 18, 2019
Merged

rpcclient: Add GetMasterPubkey #1777

merged 2 commits into from
Jul 18, 2019

Conversation

JoeGruffins
Copy link
Member

Hey. We would like to use this method in dcrstakepool. There was a scary wall of text here...

@JoeGruffins
Copy link
Member Author

I'll remove that 'k' on publick along with whatever else needs to be changed :/

@jrick
Copy link
Member

jrick commented Jul 3, 2019

This should be using hdkeychain/v2

@JoeGruffins
Copy link
Member Author

@jrick Thank you.

Does this work or is there a better way to get the network params?
Not sure why travis is angry...

@JoeGruffins JoeGruffins changed the title rpcclient: Add GetMasterPubkey [WIP] rpcclient: Add GetMasterPubkey Jul 4, 2019
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@JoeGruffins
Copy link
Member Author

Thank you!
My next step is to rebase this, correct?

This adds the GetMasterPubkey command to the rpc client, so that the
corresponding remote function can be reached.
@JoeGruffins JoeGruffins changed the title [WIP] rpcclient: Add GetMasterPubkey rpcclient: Add GetMasterPubkey Jul 8, 2019
rpcclient/wallet.go Outdated Show resolved Hide resolved
@davecgh davecgh merged commit f4aaa67 into decred:master Jul 18, 2019
@davecgh davecgh added this to the 1.5.0 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants