TravisCI: Use more portable module ver stripping. #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the script that strips the module version from listed modules for the purposes of changing to the relevant directory to be more portable by adding the -E flag to sed. This allows it to work properly on Mac as well. While here, it also switches the sed separator to a comma in the relevant removals to avoid the need to escape the slashes in the path.
jrick
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the script that strips the module version from listed modules for the purposes of changing to the relevant directory to be more portable by adding the -E flag to sed. This allows it to work properly on Mac as well.
While here, it also switches the sed separator to a comma in the relevant removals to avoid the need to escape the slashes in the path.
Thanks to @jrick for testing and the suggestion to use a comma for the sed separator.