stake: Check minimum req outputs for votes earlier. #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm the one who reported this via the Decred Slack. Looks good, thanks for fixing! |
jrick
approved these changes
Aug 7, 2019
There is no reason to perform a bunch of additional checks when there is no possible way a transaction can be vote due to not having at least the minimum required number of outputs for it to possibly be one.
davecgh
force-pushed
the
stake_vote_early_min_req_outputs_check
branch
from
242c552 to
82b863e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to perform a bunch of additional checks when there is no possible way a transaction can be vote due to not having at least the minimum required number of outputs for it to possibly be one.