main: Update to use all new major module versions. #1837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all code in the main module to use the latest major modules versions to pull in the latest updates.
A more general high level overview of the changes is provided below, however, there is one semantic change worth calling out independently.
The
verifymessage
RPC will now return an error when provided with an address that is not for the current active network and the RPC server version has been bumped accordingly.Previously, it would return false which indicated the signature is invalid, even when the provided signature was actually valid for the other network. Said behavior was not really incorrect since the
address, signature, and message combination is in fact invalid for the current active network, however, that result could be somewhat misleading since a false result could easily be interpreted to mean the signature is actually invalid altogether which is distinct from the case of the address being for a different network. Therefore, it is preferable to explicitly return an error in the case of an address on the wrong network to cleanly separate these cases.
The following is a high level overview of the changes:
calcTxTreeMerkleRoot
that acceptsdcrutil.Tx
as before and defers to the new standalone funcpeer/v2
modulechainBlockLocatorToHashes
which performs the necessary conversionv1
chaincfg
params global instances to use the newv2
functionswsClientFilter
chaincfg
constants with local constantsblockManagerConfig
BlkTmplGenerator
rpcServer
VotingWallet
v2
paramsv2
dcrjson
constant references with new types modulefees
module to use the latest major module versions and bump itv2