gcs: Optimize Hash. #1853
Merged
gcs: Optimize Hash. #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
gcs_optimize_hash
branch
from
62662f5 to
962fa5b
Compare
dnldd
approved these changes
Aug 21, 2019
jrick
approved these changes
Aug 21, 2019
This optimizes the Hash method of gcs filters by making use of the new zero-alloc hashing funcs available in crypto/blake256. The following is a before and after comparison: benchmark old ns/op new ns/op delta ------------------------------------------------- BenchmarkHash 1786 1315 -26.37% benchmark old allocs new allocs delta ------------------------------------------------- BenchmarkHash 2 0 -100.00% benchmark old bytes new bytes delta ------------------------------------------------- BenchmarkHash 176 0 -100.00%
davecgh
force-pushed
the
gcs_optimize_hash
branch
from
962fa5b to
b67fb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on top of #1851.
This adds a benchmark and optimizes the
Hashmethod of gcs filters by making use of the new zero-alloc hashing func available incrypto/blake256.The following is a before and after comparison: