mempool: Add ErrorCode to returned TxRuleErrors #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Sep 18, 2019
davecgh
reviewed
Sep 18, 2019
davecgh
requested changes
Sep 18, 2019
davecgh
approved these changes
Sep 18, 2019
matheusd
force-pushed
the
mempool-errors
branch
from
898aaf5 to
e54aa3d
Compare
This adds the ErrorCode member to TxRuleError, filling it with appropriate values throughout the mempool package. This allows clients of the package to correctly identify error causes with a greater granularity and respond appropriately. It also deprecates the RejectCode attribute and ErrToRejectError functions, to be removed in the next major version update of the package. All call sites that inspect mempool errors were updated to use the new error codes instead of using RejectionCodes. Additional mempool tests were added to ensure the correct behavior on some relevant cases. Finally, given the introduction and use of a new public field, the main module was updated to use an as-of-yet unfinished mempool v3.1.0, which will include the required functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ErrorCode member to TxRuleError, filling it with
appropriate values throughout the mempool package. This allows clients
of the package to correctly identify error causes with a greater
granularity and respond appropriately.
It also deprecates the RejectCode attribute and ErrToRejectError
functions, to be removed in the next major version update of the
package.
All call sites that inspect mempool errors were updated to use the new
error codes instead of using RejectionCodes. Additional mempool tests
were added to ensure the correct behavior on some relevant cases.
Finally, given the introduction and use of a new public field, the main
module was updated to use an as-of-yet unfinished mempool v3.1.0, which
will include the required functionality.
Close #1900