Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpctest: use errgroup to catch goroutine errors #1913

Merged
merged 3 commits into from
Oct 7, 2019
Merged

rpctest: use errgroup to catch goroutine errors #1913

merged 3 commits into from
Oct 7, 2019

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Oct 6, 2019

No description provided.

@dajohi
Copy link
Member Author

dajohi commented Oct 6, 2019

rpctest/rpc_harness_test.go:371:2: SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (staticcheck)
	go func() {
	^
rpctest/rpc_harness_test.go:393:2: SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (staticcheck)
	go func() {
	^
rpctest/rpc_harness_test.go:446:2: SA2002: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (staticcheck)
	go func() {
	^

run_tests.sh Outdated Show resolved Hide resolved
run_tests.sh Outdated Show resolved Hide resolved
run_tests.sh Outdated Show resolved Hide resolved
@davecgh davecgh changed the title rpctest: use errgroup to catch errors from go routines rpctest: use errgroup to catch goroutine errors Oct 7, 2019
@davecgh davecgh merged commit 93dc592 into decred:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants