[release-v1.5] rpcserver: Cleanup getvoteinfo RPC. #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the getvoteinfo RPC handling more consistent with the rest of the handlers and corrects the return error type for unrecognized vote versions. It also bumps the rpcserver version patch to correspond with the change.
davecgh
force-pushed
the
backport_rpcserver_cleanup_gotvoteinfo
branch
from
bbdb411 to
c84131a
Compare
jrick
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1964 to the 1.5 release branch.
It makes the
getvoteinfoRPC handling more consistent with the rest of the handlers and corrects the return error type for unrecognized vote versions.It also bumps the rpcserver version patch to correspond with the change.