Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct MaximumBlockSize is missing from /parameters #678

Closed
raedah opened this issue Sep 11, 2018 · 2 comments · Fixed by #715
Closed

correct MaximumBlockSize is missing from /parameters #678

raedah opened this issue Sep 11, 2018 · 2 comments · Fixed by #715
Labels
good first issue
Milestone
4.0

Comments

@raedah
Copy link

raedah commented Sep 11, 2018

MaximumBlockSizes
https://github.com/decred/dcrd/blob/566bb6625b83738cb97ab826d5d77e862d44e92c/chaincfg/mainnetparams.go#L33
@chappjc chappjc added this to the 3.1 milestone Sep 13, 2018
@ademuanthony ademuanthony mentioned this issue Oct 1, 2018
Merged
@chappjc
Copy link
Member

chappjc commented Oct 8, 2018

This issue should remain open until decred/dcrd#1479 is merged, and dcrdata is updated to use dcrd's new getblockchaininfo RPC, which will provide the correct block size.

@chappjc chappjc reopened this Oct 8, 2018
@chappjc chappjc changed the title MaximumBlockSizes is missing from /parameters correct MaximumBlockSize is missing from /parameters Oct 11, 2018
@chappjc chappjc modified the milestones: 3.1, 3.2 Oct 24, 2018
@chappjc chappjc mentioned this issue Nov 7, 2018
Closed
@chappjc chappjc mentioned this issue Jan 10, 2019
Merged
@chappjc
Copy link
Member

chappjc commented Jan 10, 2019

Resolved by #923

@chappjc chappjc closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

show MaximumBlockSizes parameter on the /parameters page
2 participants
@chappjc @raedah