Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain Params: add MaxBlockSize #796

Closed
xaur opened this issue Nov 6, 2018 · 4 comments
Closed

Chain Params: add MaxBlockSize #796

xaur opened this issue Nov 6, 2018 · 4 comments

Comments

@xaur
Copy link

xaur commented Nov 6, 2018

Chain Params page currently has MaxTxSize(393216 bytes, "Largest allowable transaction size") but no MaxBlockSize.

Decred mainnet maximum block size is not the same as Bitcoin and seems it is not a well known fact, which often leads to confusion (example 1, example 2). It is an important parameter that needs more exposure.
@buck54321
Copy link
Member

I think this was addressed by #715. I have it locally.

@xaur
Copy link
Author

xaur commented Nov 6, 2018

Was unaware of that PR, feel free to close when appropriate.

@chappjc
Copy link
Member

chappjc commented Nov 7, 2018

It's partially addressed. Since MaximumBlockSizes is an array, and we are just taking the first element, the displayed block size can be incorrect after a block size increase agenda item passes but before the next software update.

@chappjc
Copy link
Member

chappjc commented Nov 7, 2018

But this issue is a dup of #678, so closing.

@chappjc chappjc closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@buck54321 @chappjc @xaur