-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assets: Bump fee rate or gas cap when applicable. #1489
Comments
Can be done for eth after @martonp makes the client a |
Thanks for making an issue for this @JoeGruffins. I would only add that this issue is mainly for the taker's swap txn because they broadcast quite a bit later than the match time because maker goes first. Also, I think this is most important for assets with both volatile fees and non-dynamic-fee txns (i.e. Bitcoin).
We're really addressing this with dynamic transactions, by having the asset's Quoting myself in that other comment:
We can only bump on the above range. For eth, all we can do is just force x to MaxFeeRate if it is not already, but as we've written the server's backend, it will be. |
Related convo: #1485 (comment)
When an order is made the max fee rate is decided. When a match is made the fee rate is decided. For both account and utxo assets, some time may pass before this rate is used and a tx is sent. So, the fee may be too low at that time. When sending swaps or redeems, we can check the current fee locally, or grab from the server if needed/possible, and increase the rate if necessary. As long as the fee isn't less that what the server wants, it accepts the initiation. Fee is not checked for redeems or refunds.
This is especially important for account based assets, where a low fee can stop everything. Currently the server could send a max fee that is too low, or the fee could just increase a lot as block times are quite short and max would be set at the time of order creation, and the client would have no way to recover.
The text was updated successfully, but these errors were encountered: