Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/core: try a fresh fee rate for the init #1501

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Mar 2, 2022

Resolves #1489

When creating the swap transaction, see if a more current fee rate
should be used instead of the prescribed swap rate. This can be
particularly helpful for the taker because their swap may be a
long time after the match is made because the maker's swap must
be fully confirmed first.

If the current rate is swapRate < currentRate <= MaxFeeRate, then
use the current rate for the swap transaction.

We can also consider protocol changes where taker must get a new rate from server, and that will be enforced separately.
This current change is helpful even with that because it guards against server giving rates that are too low for whatever reason.

When creating the swap transaction, see if a more current fee rate
should be used instead of the prescribed swap rate. This can be
particularly helpful for the taker because their swap may be a
long time after the match is made because the maker's swap must
be fully confirmed first.

If the current rate is swapRate < currentRate <= MaxFeeRate, then
use the current rate for the swap transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assets: Bump fee rate or gas cap when applicable.
4 participants