packaging: package for Debian #2308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
May 9, 2023
| Version: ${VER} | ||
| Architecture: ${ARCH} | ||
| Maintainer: Decred developers <[email protected]> | ||
| Depends: libgtk-3-0, libwebkit2gtk-4.0-37 |
There was a problem hiding this comment.
Did we decide this should be libwebkit2gtk-4.0-dev (no specific revision and with -dev)?
There was a problem hiding this comment.
These are the production recommendations from https://github.com/webview/webview#linux-and-bsd
There was a problem hiding this comment.
I see. These are the runtime dependencies, not build. ✔️
The -37 part seems odd to me, but I guess that's not going to change like a revision?
chappjc
approved these changes
May 26, 2023
|
This is merged in ca5b1d8. GitHub just choked and this PR remains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add packaging script for Debian-based OS. Creates a .deb archive to install binaries, various static files, and a .desktop file.