pool: refactor payDividends. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
refactor_payDividend
branch
from
ba62f16 to
e682103
Compare
jholdstock
requested changes
Sep 22, 2020
dnldd
force-pushed
the
refactor_payDividend
branch
from
e682103 to
93010ea
Compare
This updates payment manager related errors to leverage the updated error types.
This refactors payDividends into smaller scoped helper functions that are easier to test.
This adds tests for payDividends and its helper functions.
This adds the --conftimeout config option to allow for custom tx confirmation timeouts.
This upates the tx confirmation streaming process to be non-blocking in order to terminate cleanly on context cancellation.
dnldd
force-pushed
the
refactor_payDividend
branch
from
93010ea to
9828e99
Compare
jholdstock
requested changes
Oct 7, 2020
jholdstock
requested changes
Oct 9, 2020
| initialAccountPayments := xValue + yValue | ||
| updatedAccountPaymentsPlusTxFee := out[xAddr] + out[yAddr] + txFee | ||
| if initialAccountPayments-updatedAccountPaymentsPlusTxFee <= maxRoundingDiff { | ||
| t.Fatalf("initial account payment total %v to be equal to updated "+ |
There was a problem hiding this comment.
No, applyTxFees is not using the context, therefore does not need the context cancelled for a clean shutdown.
jholdstock
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
payDividendsfunction into more targeted helper functions that are easier to test.