-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: single miner endpoint. #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
single_miner_endpoint
branch
2 times, most recently
from
November 3, 2020 10:22
fb2a537
to
240f0dc
Compare
dnldd
force-pushed
the
single_miner_endpoint
branch
from
November 26, 2020 00:15
dc7f4a0
to
d904209
Compare
This updates the miner connection config options, removing the individual config ports for supported miners in favour of a single miner connection port (--minerport).
This updates the reported miner version in a mining.subscribe message to exclude the appBuild.
This updates the endpoint config to allow finding a connected miner's difficulty. Helpers have also been added to identify a miner based on th user agent provided in its mining.subscribe message. A client disconnection process has also been added. The hub ha also been updated to only create one endpoint for all miner types.
This adds --monitorcycle and --maxupgradetries config options to allow configuring the the time spent monitoring miners for upgrades if possible.
This updates the client to provide more context for message related errors and also provides an upgrade process that monitors clients that qualify for upgrades.
This adds aditional error checks and clamp the minimum value of the difference in expected submissons and actual submissions to one.
dnldd
force-pushed
the
single_miner_endpoint
branch
from
November 26, 2020 15:58
d904209
to
f5d1f6a
Compare
Tested miner monitoring and upgrade logic with a 2020-11-27 19:26:11.637 [INF] POOL: listening on :5550
2020-11-27 19:29:25.140 [DBG] POOL: Mining client connected. extranonce1=ca750c60, addr=166.170.24.8:35258
2020-11-27 19:29:32.007 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:33.659 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:40.999 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:46.569 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:48.109 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:52.109 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:29:56.349 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:06.370 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:09.189 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:15.849 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:22.246 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:25.340 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:38.170 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:46.229 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:30:50.579 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:31:01.999 [ERR] POOL: submitted work from ca750c60/antminerdr3 is not less than the network target difficulty
2020-11-27 19:31:25.143 [INF] POOL: upgrading ca750c60/antminerdr3 to ca750c60/antminerdr5
2020-11-27 19:31:25.143 [INF] POOL: updated difficulty (228174.031) for ca750c60/antminerdr5 sent
2020-11-27 19:33:06.719 [ERR] POOL: submitted work from ca750c60/antminerdr5 is not less than the network target difficulty
2020-11-27 19:34:43.039 [ERR] POOL: submitted work from ca750c60/antminerdr5 is not less than the network target difficulty
2020-11-27 19:35:13.256 [ERR] POOL: submitted work from ca750c60/antminerdr5 is not less than the network target difficulty
2020-11-27 19:35:38.966 [ERR] POOL: submitted work from ca750c60/antminerdr5 is not less than the network target difficulty
2020-11-27 19:35:46.516 [ERR] POOL: submitted work from ca750c60/antminerdr5 is not less than the network target difficulty |
jholdstock
requested changes
Dec 2, 2020
This splits client related tests into focused units to test out targetted functionality.
jholdstock
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me! Thanks for taking the time to split up the tests, they will definitely be more manageable going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.