multi: stratum improvements. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the needed helpers for parsing and responding to extranonce.subscribe messages.
This update ParseSubscribeResponse to handle responses where a subscription id is not included. This also refactors AuthorizeRequest to handle cases where only an address is expected instead of a username.address combination.
This adds helpers for stratum error marshaling and unmarshalling. Tests have been added accordingly.
This updates rolled work notifications to indicate they are not clean/new jobs. This alo improves the error message returned, if any, on a work submission rejection. Client timeouts have also been extended to about four block times.
dnldd
force-pushed
the
stratum_improvements
branch
2 times, most recently
from
4954ccd to
0e688c0
Compare
jholdstock
reviewed
Feb 10, 2021
|
Deployed to https://pool.jholdstock.uk/ Successfully mining blocks, but still seeing a lot of errors on the pool log: |
This adds the useragent config option to the cpu miner to allow it mimic other miners. A bug related to sanitizing the pool address when it has the stratum prefix has also been fixed.
This adds more specific difficulty error types.
dnldd
force-pushed
the
stratum_improvements
branch
from
0e688c0 to
1a67908
Compare
This integrates a dynamic client timeout based on the network being mined on by the pool. This also resolves hightlighted review issues an updates some log outputs.
dnldd
force-pushed
the
stratum_improvements
branch
from
1a67908 to
4e1b6b0
Compare
jholdstock
reviewed
Feb 14, 2021
jholdstock
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends client read/write timeouts,
mining.subscriberesponse handling and other stratum related improvements.